feat(composables): introduce useDeprecated for deprecated APIs#2690
feat(composables): introduce useDeprecated for deprecated APIs#2690
Conversation
jw-foss
requested review from
a team,
Justineo,
adamdehaven and
jillztom
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Preview package from this PR in consuming applicationIn consuming application project install preview version of kongponents generated by this PR: |
adamdehaven
left a comment
adamdehaven
left a comment
There was a problem hiding this comment.
I'm not sure this change is really necessary. We may not want to always watch and continue to log the deprecations, and the logging was only put in place to aid in migration without needing to push breaking changes to the repository.
If we had gone with an approach similar to this originally I think it would have been fine, but I'm not sure it's necessary to refactor at this time
Understood, for the part "we may not want to watch and continue to log the deprecation" I can provide a
For sure, I'll close this PR if this is what we wanted. |
|
Makes sense either way. I was thinking a consistent way to handle the fraction might be helpful too, if it ends up being reused. |
4 participants
Summary
While we are doing the
typescriptimprovements, I noticed that we have quite a few places were usingvalidatorfor deprecated APIs, since we are onVue 3.5I think it is fair to migrate from that to a composition API.In this PR, I added a composable named
useDeprecatedand updatedKButtonas an example, I also included a test file against the newly added composable.KM-1149